GRP DCS DP processing#8003
Conversation
3165857 to
17f950a
Compare
There was a problem hiding this comment.
startTime is a dummy counter, it cannot be used as an alias for the time. Moreover, when it comes from the dcs-proxy, where the TF has no usual meaning, it even cannot be converted to the abs. time.
If you want, I can change the dcs2dpl to send 'now()' in the DataProcessingHeader::creation, then you can use
auto creationTime = DataRefUtils::getHeader<DataProcessingHeader*>(pc.inputs().getFirstValid(true))->creation;
directly for the time. Alternatively, you can simply use now() here. But the most precise would be extracting the timestamp from the DP itself.
There was a problem hiding this comment.
Hi Ruben,
This was the plan, I started with startTime more as a placeholder (see also our other mail exchange). I planned to add a comment to the PR, but I forgot :-)
I would use for each object probably the oldest time of all datapoints, or, as you say, "now".
This is something that should be changed in several places, which is also why I kind of postponed it.
In general, it would be better to change the dcs2dpl, also for the configurations.
There was a problem hiding this comment.
I decided to not use the timestamps of the measurements because they might be out of sync, and they could give the wrong message.
I am using now "creation", and if this is -1, then I use "now".
But I think we should set it in the proxy, same for the configurations.
There was a problem hiding this comment.
Then simply use
auto creationTime = DataRefUtils::getHeader<DataProcessingHeader*>(pc.inputs().getFirstValid(true))->creation;
I will add its filling to the proxy today.
There was a problem hiding this comment.
OK, I now have:
auto startValidity = o2::header::get<o2::framework::DataProcessingHeader*>(pc.inputs().get("input").header)->creation;
but I can change it to the one above (I guess they are equivalent, no?).
7cb874f to
584574d
Compare
584574d to
2db02c2
Compare
|
Hi @TimoWilken , @ktf , |
shahor02
left a comment
There was a problem hiding this comment.
The macOS is stuck since a few days, merging.
Eg. to run: